Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): deleted tags property cannot be added back #8761

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Nov 10, 2024

fix AF-1661

Copy link

graphite-app bot commented Nov 10, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Nov 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Nov 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e6ef1de. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.26%. Comparing base (2aceed8) to head (e6ef1de).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8761      +/-   ##
==========================================
+ Coverage   70.20%   70.26%   +0.05%     
==========================================
  Files         549      549              
  Lines       33890    33890              
  Branches     3042     3042              
==========================================
+ Hits        23793    23813      +20     
+ Misses       9727     9707      -20     
  Partials      370      370              
Flag Coverage Δ
server-test 77.18% <ø> (+0.06%) ⬆️
unittest 45.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Nov 11, 2024

Merge activity

  • Nov 10, 9:13 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 10, 9:29 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'E2E Test (4)', 'test-build-mobile-app / build-ios-web').
  • Nov 10, 9:41 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 10, 10:03 PM EST: A user merged this pull request with the Graphite merge queue.

@pengx17 pengx17 force-pushed the 11-10-fix_core_deleted_tags_property_cannot_be_added_back branch from 854151d to e6ef1de Compare November 11, 2024 02:48
@graphite-app graphite-app bot merged commit e6ef1de into canary Nov 11, 2024
46 checks passed
@graphite-app graphite-app bot deleted the 11-10-fix_core_deleted_tags_property_cannot_be_added_back branch November 11, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants